Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] issue fixed #20299 Order item details label not aligned in mobile view #20539

Merged
merged 2 commits into from
Feb 18, 2019
Merged

[Backport] issue fixed #20299 Order item details label not aligned in mobile view #20539

merged 2 commits into from
Feb 18, 2019

Conversation

irajneeshgupta
Copy link
Member

Original Pull Request

#20301
issue fixed #20299 Order item details label not aligned in mobile view

Manual testing scenarios (*)

Step 1: Open frontend and login as customer
Step 2: Go to my account section
Step 3: Click on My order link and open detail any order in mobile
Step 4: You will issue as shown in screenshot

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

cedarvinda and others added 2 commits January 23, 2019 18:09
@cedarvinda @irajneeshgupta
issue fixed magento#20299 Order item details label not aligned in mob…
867f474 
…ile view

issue fixed magento#20299 Order item details label not aligned in mobile view
@nmalevanec @irajneeshgupta
Fix static tests.
362f81f
@magento-engcom-team
Copy link
Contributor

Hi @irajneeshgupta. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Jan 28, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-4013 has been created to process this Pull Request

@okorshenko okorshenko removed this from the Release: 2.2.8 milestone Jan 28, 2019
@magento-engcom-team magento-engcom-team mentioned this pull request Feb 18, 2019
Closed
@magento-engcom-team magento-engcom-team merged commit 362f81f into magento:2.2-develop Feb 18, 2019
@ghost
Copy link

ghost commented Feb 18, 2019

Hi @irajneeshgupta, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Feb 18, 2019
@sivaschenko
ENGCOM-4013: [Backport] issue fixed #20299 Order item details label n…
b14efd8 
…ot aligned in mobile view #20539
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.9 milestone Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidolov sidolov sidolov approved these changes

@VladimirZaets VladimirZaets Awaiting requested review from VladimirZaets

Assignees

@sidolov sidolov

Labels
Area: Design/Frontend Community Insider: Cedcommerce community-insider-contribution Progress: accept Release Line: 2.2
Projects
None yet
Milestone
Release: 2.2.9
Development

Successfully merging this pull request may close these issues.
6 participants
@irajneeshgupta @magento-engcom-team @sidolov @okorshenko @cedarvinda @nmalevanec